Skip to content

PO-1849#2417

Merged
jonathanDuffy merged 28 commits intomasterfrom
PO-1849
Apr 10, 2026
Merged

PO-1849#2417
jonathanDuffy merged 28 commits intomasterfrom
PO-1849

Conversation

@Arnabsubedi233
Copy link
Copy Markdown
Contributor

@Arnabsubedi233 Arnabsubedi233 commented Apr 2, 2026

Jira link

See https://tools.hmcts.net/jira/browse/PO-1849

Change description

  • Added the enforcement court change attribute

Testing done

  • Unit tested
  • Local tested

Security Vulnerability Assessment

CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?

  • Yes
  • No

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@Arnabsubedi233 Arnabsubedi233 self-assigned this Apr 2, 2026
iamfrankiemoran
iamfrankiemoran requested changes Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@iamfrankiemoran iamfrankiemoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes, but talk on Tuesday about it

Comment thread ...c-defendant-details-enforcement-tab/fines-acc-defendant-details-enforcement-tab.component.ts Outdated
Comment thread ...c-defendant-details-enforcement-tab/fines-acc-defendant-details-enforcement-tab.component.ts
Comment thread ...defendant-details-enforcement-tab/fines-acc-defendant-details-enforcement-tab.component.html
Comment thread ...defendant-details-enforcement-tab/fines-acc-defendant-details-enforcement-tab.component.html
Comment thread ...p/flows/fines/fines-acc/fines-acc-defendant-details/fines-acc-defendant-details.component.ts Outdated
Comment thread ...fines-acc/fines-acc-enf-court-change/interfaces/fines-acc-enf-court-change-form.interface.ts
Comment thread ...app/flows/fines/fines-acc/fines-acc-enf-court-change/fines-acc-enf-court-change.component.ts Outdated
Comment thread src/app/flows/fines/fines-acc/routing/resolvers/fetch-courts-resolver/fetch-courts.resolver.ts Outdated
iamfrankiemoran
iamfrankiemoran approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@iamfrankiemoran iamfrankiemoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

louisbriggs
louisbriggs requested changes Apr 7, 2026
View reviewed changes
Comment thread ...opal-fines-service/constants/opal-fines-defendant-account-patch-payload-defaults.constant.ts Outdated
Comment thread ...ines/services/opal-fines-service/interfaces/opal-fines-update-defendant-account.interface.ts
louisbriggs
louisbriggs approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@louisbriggs louisbriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanDuffy jonathanDuffy enabled auto-merge (squash) April 10, 2026 12:52
@jonathanDuffy jonathanDuffy merged commit 29e6708 into master Apr 10, 2026
5 checks passed
@jonathanDuffy jonathanDuffy deleted the PO-1849 branch April 10, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamfrankiemoran iamfrankiemoran iamfrankiemoran approved these changes

@louisbriggs louisbriggs louisbriggs approved these changes

@max-holland max-holland Awaiting requested review from max-holland

@ChrisGarratt122 ChrisGarratt122 Awaiting requested review from ChrisGarratt122

Assignees

@Arnabsubedi233 Arnabsubedi233

Labels

ns:opal prd:opal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Arnabsubedi233 @iamfrankiemoran @louisbriggs @jonathanDuffy @CadeFaulkner